Skip to content

Conversation

@halx99
Copy link
Collaborator

@halx99 halx99 commented Jul 16, 2025

Describe your changes

  • Rename GLView to RenderView
  • Rename RenderView method: isOpenGLReady to isGfxContextReady
  • Rename struct GLContextAttrs to GfxContextAttrs
  • Rename RenderView method: setGLContextAttrs to setGfxContextAttrs
  • Rename RenderView method: getGLContextAttrs to getGfxContextAttrs
  • All renamed stub has compatible typedef like: AX_DEPRECATED(2.8) typedef NewName OldName;

Affects

  • User can upgrade from axmol-2.7 without game code changes, but will encouter some deprecated warnings

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 added this to the 2.8.0 milestone Jul 16, 2025
@halx99 halx99 added the enhancement New feature or request label Jul 16, 2025
@halx99 halx99 force-pushed the rename-glview-to-renderview branch from a05294b to 2142504 Compare July 16, 2025 03:43
@halx99 halx99 merged commit ca5801e into dev Jul 16, 2025
15 checks passed
@halx99 halx99 deleted the rename-glview-to-renderview branch July 16, 2025 08:38
halx99 added a commit that referenced this pull request Jul 16, 2025
halx99 added a commit that referenced this pull request Jul 16, 2025
* Fix missing renaming #2602

* Update docs/DevSetup.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants