Skip to content

Axios response headers may be undefined#4813

Merged
jasonsaayman merged 2 commits intoaxios:v0.xfrom
gprst:fix/axios-response-headers-typing
Aug 10, 2022
Merged

Axios response headers may be undefined#4813
jasonsaayman merged 2 commits intoaxios:v0.xfrom
gprst:fix/axios-response-headers-typing

Conversation

@gprst
Copy link
Copy Markdown

@gprst gprst commented Jun 25, 2022

This PR is to fix the AxiosResponseHeaders type on the v0.x branch, that currently does not reflect the fact that response headers can be undefined. This seems to be already fixed in the RawAxiosResponseHeaders type on the v1.x branch.

Fixes #4812

@gprst gprst force-pushed the fix/axios-response-headers-typing branch 2 times, most recently from c5b19b1 to 0c338d9 Compare June 25, 2022 21:44
@gprst gprst force-pushed the fix/axios-response-headers-typing branch from a0c67f4 to 4b7a2a7 Compare June 26, 2022 09:47
@gprst gprst changed the base branch from v1.x to v0.x June 26, 2022 09:48
@jasonsaayman jasonsaayman changed the title Axios response headers can be undefined Axios response headers may be undefined Aug 8, 2022
@jasonsaayman jasonsaayman changed the base branch from v0.x to v1.x August 8, 2022 16:21
@jasonsaayman jasonsaayman changed the base branch from v1.x to v0.x August 8, 2022 16:22
@jasonsaayman jasonsaayman merged commit bbb2264 into axios:v0.x Aug 10, 2022
phloose pushed a commit to phloose/axios that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Axios response headers can be undefined (TS typing isn't strict enough)

2 participants