Adding error handling inside stream end callback#3967
Merged
jasonsaayman merged 4 commits intoaxios:masterfrom Dec 23, 2021
Merged
Adding error handling inside stream end callback#3967jasonsaayman merged 4 commits intoaxios:masterfrom
jasonsaayman merged 4 commits intoaxios:masterfrom
Conversation
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
* Adding error handling inside end callback for response streams * Updating error handling in stream end callback * Update http.js Co-authored-by: Jay <jasonsaayman@gmail.com>
This was referenced Feb 22, 2022
This was referenced Mar 9, 2022
This was referenced Oct 27, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #3941. When the response is a stream and an error happens inside the end callback, there is no error handling present and this PR fixes it.