Skip to content

Fix build #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felipewmartins merged 5 commits into from
Oct 25, 2019
Merged

Fix build #2496

felipewmartins merged 5 commits into from
Oct 25, 2019

Conversation

@felipewmartins
Copy link
Contributor

@felipewmartins felipewmartins commented Oct 25, 2019

Instructions

Please read and follow the instructions before creating and submitting a pull request:

  • Create an issue explaining the feature. It could save you some effort in case we don't consider it should be included in axios.
  • If you're fixing a bug, try to commit the failing test/s and the code fixing it in different commits.
  • Ensure you're following our contributing guide.

⚠️👆 Delete the instructions before submitting the pull request 👆⚠️

Describe your pull request here.

@felipewmartins felipewmartins merged commit d2f36ee into axios:revert-2410-webpack-and-deps Oct 25, 2019
felipewmartins added a commit that referenced this pull request Oct 25, 2019
@felipewmartins
Revert "Update Webpack + deps, remove now unnecessary polyfills" (#2479)
0979486 
* Revert "Update Webpack + deps, remove now unnecessary polyfills (#2410)"

This reverts commit 189b34c.

* Fix build (#2496)

* Change syntax to see if build passes

* Test commit

* Test with node 10

* Test adding all browsers in travis

* remove other browsers when running on travis
@yasuf
Copy link
Collaborator

yasuf commented Oct 25, 2019

glad the build passed this time around

@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felipewmartins @yasuf