Skip to content

Fixing set config.method after mergeConfig for Axios.prototype.request #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felipewmartins merged 1 commit into from
Sep 6, 2019
Merged

Fixing set config.method after mergeConfig for Axios.prototype.request #2383

felipewmartins merged 1 commit into from
Sep 6, 2019

Conversation

@bushuai
Copy link
Contributor

@bushuai bushuai commented Aug 30, 2019

Inside Axios.prototype.request function

It's forced to set config.method to GET after mergeConfig if config.method exists
which makes the defaults.method not effective.

// Set default options
const instance = axios.create({ method: 'post', /* options */ })

// use instance.request() or instance()
instance({ url })            
instance.request({ url })

HTTP method should be POST above.

@felipewmartins
Copy link
Contributor

felipewmartins commented Sep 6, 2019

Hi @bushuai, can you update your local branch?

@bushuai
Fixing set config.method after mergeConfig for Axios.prototype.request
735f99b 
Inside Axios.prototype.request function, It's forced to set
method to 'get' after `mergeConfig` if config.method exists, which makes the defaults.method not effective.
@felipewmartins felipewmartins merged commit e50a08b into axios:master Sep 6, 2019
@felipewmartins
Copy link
Contributor

felipewmartins commented Sep 6, 2019

Thanks @bushuai

genie-youn pushed a commit to genie-youn/axios that referenced this pull request Sep 27, 2019
@bushuai @genie-youn
Fixing set config.method after mergeConfig for Axios.prototype.requ…
fecdd07 
…est (axios#2383)

Inside Axios.prototype.request function, It's forced to set
method to 'get' after `mergeConfig` if config.method exists, which makes the defaults.method not effective.
@chinesedfan chinesedfan mentioned this pull request Dec 7, 2019
Closed
This was referenced Jan 7, 2020
Open
Open
Open
Closed
Merged
Closed
Open
Merged
Open
Merged
Merged
Merged
Merged
Closed
Merged
Open
Open
Merged
Open
Open
Open
This was referenced Apr 3, 2020
Open
Open
Closed
Open
Closed
Merged
Closed
Open
Closed
Closed
Merged
Merged
Merged
Open
Open
Open
This was referenced Apr 13, 2020
Open
Open
Open
Closed
This was referenced Apr 21, 2020
Open
Open
Open
Open
Open
Open
This was referenced Apr 30, 2020
Open
Open
Merged
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@felipewmartins felipewmartins Awaiting requested review from felipewmartins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bushuai @felipewmartins