Fixing issue 2195 #2201
Fixing issue 2195 #2201
Conversation
jasonsaayman
left a comment
There was a problem hiding this comment.
I have tested this and it seems that this does not break anything however it does definitely mend #2195
|
@emilyemorehouse would it be possible to get an ETA for when this could be merged? I'd like to update my team/management on the fix for this issue. |
|
Is anyone able to merge changes other than @emilyemorehouse? This is becoming a hindrance to us continuing to use this library, if we can't get timely responses to get fixes handled. |
|
@jmelvin-r7, unfortunately, I think its only Emily and the three other original maintainers at this time. |
|
@emilyemorehouse @mzabriskie @nickuraltsev @rubennorte Going to tag all of you. This issue is really becoming a bother and a forced downgrade to 0.18.0 is the only way to prevent it, but if this PR can be merged and a new release (0.19.1?) be made that would be great. |
Fixes #2195
The order of the if/else blocks matters when running tests mocking XHR. Changing the order allows this to continue working in node and browsers, but also allows for unit tests to properly connect over the correct protocol.