fix: resolveConfig arrow function breaks under webpack + babel transforms#10891
Merged
jasonsaayman merged 2 commits intoMay 24, 2026
Merged
Conversation
…ck/babel compatibility
jasonsaayman
approved these changes
May 24, 2026
jasonsaayman
added a commit
that referenced
this pull request
May 28, 2026
…ck/babel compatibility (#10891) Co-authored-by: Jay <jasonsaayman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this while bundling an app with webpack 5 + babel. The arrow function
used as the default export in
resolveConfig.jscauses__WEBPACK_DEFAULT_EXPORT__to resolve to
undefinedunder certain babel plugin configurations (specificallywith
@babel/plugin-transform-modules-commonjsand module interop settings).Converting it to a named function export resolves the issue without any
behavioral changes.
Tested with the repro case from #10675.
Summary by cubic
Fixes an issue where
resolveConfig’s default export could be undefined when bundling withwebpack 5+babelCommonJS transforms. Converts the arrow default export to a named function and re-exports it as default; no behavior or API changes.Description
resolveConfigand default-export it.@babel/plugin-transform-modules-commonjscan break arrow default exports inwebpack 5, causing__WEBPACK_DEFAULT_EXPORT__to be undefined.v1.xinto this branch with no additional code changes./docs/aboutbabelCommonJS interop and default exports.Testing
resolveConfig.webpack 5+@babel/plugin-transform-modules-commonjsto prevent regressions.Written for commit eb5978c. Summary will update on new commits. Review in cubic