Skip to content

Update to 1.21.9#149

Merged
axieum merged 7 commits intoaxieum:mainfrom
PSJahn:main
Nov 30, 2025
Merged

Update to 1.21.9#149
axieum merged 7 commits intoaxieum:mainfrom
PSJahn:main

Conversation

@PSJahn
Copy link
Copy Markdown
Contributor

@PSJahn PSJahn commented Oct 1, 2025

Initial proposal for updating to 1.21.9, feel free to edit.

The async auth task with the many Minecraft#execute statements is probably the ugliest part of this update, but is necessary so that StringWidget#setMessage is ran on the main thread (otherwise the client crashes because the Rendersystem would be called from the wrong thread), though it could probably be reformatted to be prettier.

@github-actions github-actions bot added build Improvements or additions to the build process fabric Improvements or additions to the Fabric distribution common labels Oct 1, 2025
@copyandexecute
Copy link
Copy Markdown

copyandexecute commented Oct 2, 2025

looks amazing to me

@FySjutton
Copy link
Copy Markdown

FySjutton commented Oct 23, 2025

Does crash when trying to join singleplayer worlds.

@PSJahn
Copy link
Copy Markdown
Contributor Author

PSJahn commented Oct 23, 2025

Does crash when trying to join singleplayer worlds.

Can you attach the error message? This hasn't happened to me.

axieum
axieum reviewed Oct 24, 2025
View reviewed changes
@axieum
Copy link
Copy Markdown
Owner

axieum commented Oct 24, 2025

This looks great thank you, sorry this got forgotten about.

If we can be sure @FySjutton's issue is related to this PR's version, then we should look into it.

I am busy moving house at the moment, so I am limited in time and PC-availability.

@FySjutton
Copy link
Copy Markdown

FySjutton commented Oct 24, 2025

The crash is caused by resourcefulconfig, embedded within AuthMe.
Got this crash report from a friend: https://mclo.gs/VrDFuQu

@FySjutton
Copy link
Copy Markdown

FySjutton commented Oct 24, 2025

I've also experienced some issues that it sometimes says that an error occurred in red text, but it still signs me in if I go back. Not sure what causes that though.

@bosstfex
Copy link
Copy Markdown

bosstfex commented Oct 25, 2025

yes

@FySjutton
Copy link
Copy Markdown

FySjutton commented Oct 31, 2025

Found another issue, a rather major one, opening the config for Authme results in a single-colored screen without anything on it, that cannot be closed. (Need to close minecraft completely to get rid of it!)

@GahahaWang
Copy link
Copy Markdown

GahahaWang commented Nov 4, 2025

Found another issue, a rather major one, opening the config for Authme results in a single-colored screen without anything on it, that cannot be closed. (Need to close minecraft completely to get rid of it!)

that's a resourceful config dependency version i guess, so i fix that in fabric.mod.json and neoforge.mods.toml
not sure if it works on neoforge because i never use neoforge, but works well on fabric
PSJahn #2

@Scubakay Scubakay mentioned this pull request Nov 4, 2025
Closed
@Scubakay
Copy link
Copy Markdown

Scubakay commented Nov 8, 2025

How's the new house?

@axieum
Copy link
Copy Markdown
Owner

axieum commented Nov 8, 2025

How's the new house?

It's great thanks, still so much to sort out and things to get as I find I need them 😆

I'm looking into this PR now, shouldn't be too long!

@github-actions github-actions bot removed the fabric Improvements or additions to the Fabric distribution label Nov 8, 2025
@axieum
Copy link
Copy Markdown
Owner

axieum commented Nov 8, 2025 •
edited
Loading

I am having issues getting the NeoForge dist to run, but the errors seem to be internal to NeoForge and Java RandomGenerator illegal state exceptions.

Perhaps this is just my development environment, as I can't even open NeoForge's built-in mod menu either.

  • I will test the built mod jars from this PR's action output and validate against production before merging this PR.

https://github.com/axieum/authme/actions/runs/19194128683?pr=149

@axieum
Copy link
Copy Markdown
Owner

axieum commented Nov 9, 2025

The Fabric version works flawlessly in production. The NeoForge variant has so many very obscure crashes, I cannot open the Mods menu, and clicking the Microsoft login button just crashes due to the following line -

authme/common/src/main/java/me/axieum/mcmod/authme/api/util/MicrosoftUtils.java

Lines 70 to 71 in 1b3b833

/** A secure random for OAuth2 state generation. */
private static final RandomGenerator SECURE_RANDOM = RandomGenerator.of("SecureRandom");

@axieum axieum mentioned this pull request Nov 29, 2025
Closed
@axieum
refactor: change RandomGenerator#of to new SecureRandom()
d93445d 
This is due to NeoForge recently duplicating the random generator service providers, breaking its use.
@axieum
Copy link
Copy Markdown
Owner

axieum commented Nov 30, 2025

The NeoForge mods menu still doesn't open but this is a NeoForge problem. I tried a fresh 1.21.9 NeoForge without my mod and it still crashes when you click "Mods" HAHA.

@axieum axieum merged commit 0a2f677 into axieum:main Nov 30, 2025
2 checks passed
axieum pushed a commit that referenced this pull request Nov 30, 2025
@PSJahn @axieum
build: add support for Minecraft 1.21.9+ (#149)
a23ec85 
Release-As: 9.0.1+1.21.9
@github-actions github-actions bot mentioned this pull request Nov 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axieum axieum axieum left review comments

+1 more reviewer

@FySjutton FySjutton FySjutton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Improvements or additions to the build process common

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@PSJahn @copyandexecute @FySjutton @axieum @bosstfex @GahahaWang @Scubakay