Conversation
milapsheth
reviewed
Jul 21, 2022
|
|
||
| # add '--no-password' and '--unsafe' flags to args if enabled | ||
| ARGS=${NOPASSWORD:+"${ARGS} --no-password"} | ||
| ARGS=${NOPASSWORD:+"--no-password"} |
Member
There was a problem hiding this comment.
Why remove ARG? You're modifying the args env var so need to retain all of them. Or update the individual env var, and makes ARGS the concatenation?
Contributor
Author
There was a problem hiding this comment.
I add to remove ARGs because the arguments weren't getting concatenated at all. Suppose ADDRESS is set but PORT was not set. Everything concatenated up to ADDRESS would be there, but then ARGS would be replaced by an empty value. Instead, I am using the += operator for assigning the returned value, which fixes the issue.
Contributor
There was a problem hiding this comment.
consider removing lines 60-61 since ARGS is initialized here
talalashraf
pushed a commit
that referenced
this pull request
Jul 20, 2023
talalashraf
pushed a commit
that referenced
this pull request
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MNEMONIC_CMDenv var would be used by the entrypoint when starting tofnd--addressand--portin the entrypoint via env varsADDRESSandPORT