fix: update delegations code#933
Merged
Merged
Conversation
jmt-lab
approved these changes
Apr 23, 2026
| &metadata_outdir, | ||
| ) | ||
| .await?; | ||
| if let Some(bytes) = self.delegated_metadata_bytes.get(name) { |
Contributor
There was a problem hiding this comment.
This could be folded (surprised clippy didn't get ya for it)
if let Some(filename) = self.delegated_filename(name) && let Some(bytes) = self.delegated_metadata_bytes.get(name)
This might be tied to edition 2024 not sure
Contributor
Author
There was a problem hiding this comment.
#932 fixes the too_many_lines error. I'll repush once that merges
Co-authored-by: Shikha Vyaghra <vyaghras@amazon.com> Signed-off-by: Richard Kelly <rpkelly@amazon.com>
qianxjcraig
approved these changes
Apr 24, 2026
ginglis13
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update delegated target handling.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.