fix: update file writing#932
Merged
Merged
Conversation
rpkelly
approved these changes
Apr 23, 2026
jmt-lab
reviewed
Apr 23, 2026
| .context(error::FileWriteSnafu { path }) | ||
| let buf = self.buffer.clone(); | ||
|
|
||
| tokio::task::spawn_blocking(move || { |
Contributor
There was a problem hiding this comment.
Can we try to use tokio::io::write_all and remove spawn_blocking
jmt-lab
reviewed
Apr 23, 2026
| file.flush() | ||
| .await | ||
| .context(error::CacheFileWriteSnafu { path: outpath }) | ||
| tokio::task::spawn_blocking(move || { |
jmt-lab
reviewed
Apr 23, 2026
| let mut file = tokio::fs::File::create(&path) | ||
| .await | ||
| .context(error::FileWriteSnafu { path: &path })?; | ||
| file.write_all(&self.buffer) |
Contributor
There was a problem hiding this comment.
nit: i'd prefer we add a file.flush().await
Signed-off-by: Jingwei Wang <jweiw@amazon.com>
jmt-lab
approved these changes
Apr 23, 2026
Signed-off-by: Jingwei Wang <jweiw@amazon.com>
ginglis13
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
update file writing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.