Fix/replace openssl shellout with aws lc rs#923
Merged
jmt-lab merged 3 commits intoMar 23, 2026
Merged
Conversation
Contributor
|
Yay 🎉 |
Contributor
|
Code changes look fine to me. Can you run |
Contributor
Author
|
Done |
yeazelm
approved these changes
Mar 16, 2026
yeazelm
left a comment
There was a problem hiding this comment.
Thanks for the contribution @jeremydosborn !
Contributor
Author
|
Of course! Thanks everyone. |
bcressey
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #627
gen-rsa-keywas shelling out to the systemopensslbinary to generate RSA keys. When #825 migrated the crypto backend fromringtoaws-lc-rs, this shell-out was not addressed — RSA key generation viaaws-lc-rsmay not have been available at the time.This PR replaces the
std::process::Commandopenssl shell-out withaws-lc-rs, which is already a dependency.Changes:
gen_rsa_keynow usesaws_lc_rs::rsa::PrivateDecryptingKeyfor key generation--bitsrestricted to 2048, 3072, 4096 — other values return a clear error--expretained for CLI compatibility but ignored if non-65537, with a warningCommandExec,CommandStatus,CommandUtf8base64 = "0.22"as a new dependency for DER-to-PEM encodinggen_rsa_key_and_sign_rootandgen_rsa_key_unsupported_size_failsTesting:
cargo testpasses (full workspace).Note: the snakeoil test fixtures in
tests/data/could be regenerated using the new code path to provide additional coverage, if the maintainers wish to do so in a follow-up.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.