Use aws-lc-rs in place of ring#825
Merged
Merged
Conversation
751872c to
b1646e1
Compare
Contributor
Author
|
^ force pushed a rebase |
b1646e1 to
a4e7678
Compare
Contributor
Author
|
^ skip untrusted v0.7.1 in license check; also bring |
Enable `prebuilt-nasm` feature for Windows. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
Enable `prebuilt-nasm` feature for Windows Signed-off-by: Gavin Inglis <giinglis@amazon.com>
Signed-off-by: Gavin Inglis <giinglis@amazon.com>
aws-lc-rs pins to untrusted v0.7.1; skip this crate in license checks Signed-off-by: Gavin Inglis <giinglis@amazon.com>
f4d2a8b to
f8f9b7e
Compare
bcressey
reviewed
Sep 16, 2024
jpculp
approved these changes
Sep 18, 2024
2 tasks
bcressey
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#824
Description of changes:
Migrate from
ringtoaws-lc-rs. Testing thus far has been simplycargo testandmake integ.The
untrustedcrate thattoughdepends on is downgraded to0.7.1as a consequence ofaws-lc-rspinning to this version of the crate; it is now required intoughby thering-iodefault feature ofaws-lc-rs, which providesaws_lc_rs::io::der.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.