Add code formatting and type checking with Black, isort, and mypy#20
Merged
Merged
Conversation
anilkmr-a2z
approved these changes
Nov 3, 2025
anilkmr-a2z
left a comment
Contributor
There was a problem hiding this comment.
I would recommend adding some more details to the commit messages. Otherwise it may not make much after sometime.
Contributor
Author
@anilkmr-a2z Let me know if that is better. Thanks for the feedback |
haofeif
added a commit
that referenced
this pull request
Apr 4, 2026
…dation, and README docs - Rename lessons-learned.md to lessons-learnt.md - Add 7 new lessons (#14-#20): shell warm-up, TERM compatibility, alt-screen vs scrollback, startup prompt loop, stale permission detection, per-directory locks, assign+handoff e2e validation - Add docs/tool-restrictions.md as essential reading reference - Add assign+handoff orchestration step (Step 9) to SKILL.md with troubleshooting guide referencing examples/assign/ - Add alt-screen vs scrollback to "Before You Start" checklist - Expand Step 6 with cross-references to lessons #14, #15, #17 - Fix stale lessons-learned.md reference in provider-template.md - Add Skills section to README with tool compatibility table (Claude Code, Kiro CLI, Gemini CLI, Strands Agents SDK, Microsoft Agent Framework, etc.) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
haofeif
added a commit
that referenced
this pull request
Apr 4, 2026
The launch commands in lesson #20 and SKILL.md Step 9 were missing --provider (defaults to kiro_cli otherwise) and --auto-approve/--yolo flags needed for new provider testing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
haofeif
added a commit
that referenced
this pull request
Apr 4, 2026
…ss criteria Detail each test across 5 suites (handoff, assign, send_message, allowed_tools, supervisor_orchestration) with what it validates and why it matters. Emphasize that all 11 must pass — a supervisor that silently does workers' jobs or ignores tool restrictions is only caught by the full suite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fanhongy
pushed a commit
that referenced
this pull request
Apr 7, 2026
* feat: add cao-provider skill for scaffolding new CLI agent providers Comprehensive skill with annotated template, 10 lessons learned from building 7 providers, test guide, and step-by-step implementation checklist. Placed in skills/ (not .claude/) so it's tool-agnostic for any AI assistant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat(skill): enhance cao-provider skill with lessons learnt, e2e validation, and README docs - Rename lessons-learned.md to lessons-learnt.md - Add 7 new lessons (#14-#20): shell warm-up, TERM compatibility, alt-screen vs scrollback, startup prompt loop, stale permission detection, per-directory locks, assign+handoff e2e validation - Add docs/tool-restrictions.md as essential reading reference - Add assign+handoff orchestration step (Step 9) to SKILL.md with troubleshooting guide referencing examples/assign/ - Add alt-screen vs scrollback to "Before You Start" checklist - Expand Step 6 with cross-references to lessons #14, #15, #17 - Fix stale lessons-learned.md reference in provider-template.md - Add Skills section to README with tool compatibility table (Claude Code, Kiro CLI, Gemini CLI, Strands Agents SDK, Microsoft Agent Framework, etc.) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(skill): add --provider and --auto-approve to assign e2e examples The launch commands in lesson #20 and SKILL.md Step 9 were missing --provider (defaults to kiro_cli otherwise) and --auto-approve/--yolo flags needed for new provider testing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs(skill): expand lesson #20 with all 11 e2e tests as minimum success criteria Detail each test across 5 suites (handoff, assign, send_message, allowed_tools, supervisor_orchestration) with what it validates and why it matters. Emphasize that all 11 must pass — a supervisor that silently does workers' jobs or ignores tool restrictions is only caught by the full suite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces consistent code formatting and static type checking across the entire codebase.
Changes
mypy.iniwith project-specific type checking rulesFiles Changed
Affected Areas
Commits
Benefits
Testing
All existing tests pass with the formatting and type checking changes applied.