Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d472f64). Learn more about missing BASE report.

@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage        ?   91.71%           
=======================================
  Files           ?       55           
  Lines           ?     4394           
  Branches        ?        0           
=======================================
  Hits            ?     4030           
  Misses          ?      364           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilkmr-a2z thanks for the great work. just some minor comments:

1 — Unrelated test_launch.py assertion change — Priority: Medium

# before
assert params["working_directory"] == os.path.realpath(os.getcwd())
# after
assert params["working_directory"] == os.getcwd()

Why this is worth flagging:

• Production at src/cli_agent_orchestrator/cli/commands/launch.py:53 still calls os.path.realpath(os.getcwd()) — unchanged by this PR.
• The new assertion no longer verifies the realpath() behavior. On platforms where CWD is a symlink (e.g. macOS /tmp → /private/tmp), the test will assert the unresolved path while production sends the resolved path — the opposite of what we want.
• On typical dev/CI paths (/Users/..., /home/..., /workspace/...) there are no symlinks, so both old and new assertions pass — which is probably why this slipped past local validation. It's not currently red, but it's a weakened contract.
• The PR description frames this as reflecting "working-directory inheritance behavior," but realpath() resolves symlinks, not inheritance — the stated rationale doesn't match what the code change does.

Scope concern: this change has nothing to do with the agent-profile fix. Mixing an unrelated assertion rewrite into a targeted regression fix makes the PR harder to revert cleanly if something downstream breaks.

Suggested action (pick one):

1. Preferred — revert this hunk; the agent-profile fix stands on its own.
2. If there's a real reason to drop realpath() (e.g. symlink-resolution caused a real incident), change production instead and document it in a separate PR.
3. If keeping the change, update the commit body to explain why the assertion was weakened so future readers understand.

2 — Dead except FileNotFoundError — Priority: Low

After the new outer guard, the inner handler is unreachable:

try:
    profile = load_agent_profile(agent_profile)   # ← now handled by outer guard
except FileNotFoundError:
    profile = None

...

if allowed_tools is None and profile is not None:
    try:
        from cli_agent_orchestrator.utils.tool_mapping import resolve_allowed_tools

        mcp_server_names = list(profile.mcpServers.keys()) if profile.mcpServers else None
        allowed_tools = resolve_allowed_tools(
            profile.allowedTools, profile.role, mcp_server_names
        )
    except FileNotFoundError:   # ← dead: resolve_allowed_tools is pure list/dict manipulation
        pass

Confirmed by reading src/cli_agent_orchestrator/utils/tool_mapping.py:75-115 — resolve_allowed_tools() is pure list/dict manipulation sourced from ROLE_TOOL_DEFAULTS, no file I/O, cannot raise FileNotFoundError.

Suggested action: remove the inner try/except, de-indent the resolve_allowed_tools call. Cosmetic only — fine as a follow-up if preferred.

@anilkmr-a2z thanks for the great work. just some minor comments:

1 — Unrelated test_launch.py assertion change — Priority: Medium

# before
assert params["working_directory"] == os.path.realpath(os.getcwd())
# after
assert params["working_directory"] == os.getcwd()

Why this is worth flagging:

* Production at `src/cli_agent_orchestrator/cli/commands/launch.py:53` still calls `os.path.realpath(os.getcwd())` — unchanged by this PR.

* The new assertion no longer verifies the `realpath()` behavior. On platforms where CWD is a symlink (e.g. macOS `/tmp → /private/tmp`), the test will assert the _unresolved_ path while production sends the _resolved_ path — the opposite of what we want.

* On typical dev/CI paths (`/Users/...`, `/home/...`, `/workspace/...`) there are no symlinks, so both old and new assertions pass — which is probably why this slipped past local validation. It's not _currently_ red, but it's a weakened contract.

* The PR description frames this as reflecting "working-directory inheritance behavior," but `realpath()` resolves symlinks, not inheritance — the stated rationale doesn't match what the code change does.

Scope concern: this change has nothing to do with the agent-profile fix. Mixing an unrelated assertion rewrite into a targeted regression fix makes the PR harder to revert cleanly if something downstream breaks.

Suggested action (pick one):

1. **Preferred** — revert this hunk; the agent-profile fix stands on its own.

2. If there's a real reason to drop `realpath()` (e.g. symlink-resolution caused a real incident), change production instead and document it in a separate PR.

3. If keeping the change, update the commit body to explain _why_ the assertion was weakened so future readers understand.

2 — Dead except FileNotFoundError — Priority: Low

After the new outer guard, the inner handler is unreachable:

try:
    profile = load_agent_profile(agent_profile)   # ← now handled by outer guard
except FileNotFoundError:
    profile = None

...

if allowed_tools is None and profile is not None:
    try:
        from cli_agent_orchestrator.utils.tool_mapping import resolve_allowed_tools

        mcp_server_names = list(profile.mcpServers.keys()) if profile.mcpServers else None
        allowed_tools = resolve_allowed_tools(
            profile.allowedTools, profile.role, mcp_server_names
        )
    except FileNotFoundError:   # ← dead: resolve_allowed_tools is pure list/dict manipulation
        pass

Confirmed by reading src/cli_agent_orchestrator/utils/tool_mapping.py:75-115 — resolve_allowed_tools() is pure list/dict manipulation sourced from ROLE_TOOL_DEFAULTS, no file I/O, cannot raise FileNotFoundError.

Suggested action: remove the inner try/except, de-indent the resolve_allowed_tools call. Cosmetic only — fine as a follow-up if preferred.

Good catch. Fixed these.