Format Java files#11
Merged
Merged
Conversation
Contributor
Author
|
Looks like there is a competing format somewhere in the build, will try to figure out which it uses and more that to the pre-commit checks if possible. |
Contributor
Author
|
There was a formatting plugin used by only the Hibernate example, but it didn't apply to the dialect code. I've removed it since we are now formatting at the top level so it is unnecessary for the example to have a dedicated plugin. Conflict should be resolved. |
amaksimo
approved these changes
Jan 28, 2026
danielfrankcom
added a commit
that referenced
this pull request
Jan 28, 2026
This PR consolidates development tooling and CI workflows from the individual project repos into a monorepo-compatible format at the top level. ### Changes Pre-commit hooks (`.pre-commit-config.yaml`) - Added root-level pre-commit config covering all projects - Python: `ruff` (lint + format), `pyright` (sqlalchemy, tortoise-orm only) - Java: Google Java formatter - YAML: prettier - GitHub Actions: actionlint - Secrets: gitleaks - Removed per-project `.pre-commit-config.yaml` files (sqlalchemy, tortoise-orm) CI workflows - Added pre-commit workflow to run pre-commit checks - Removed redundant lint jobs from Python CI workflows (now handled by pre-commit workflow) - Added build step to sqlalchemy and tortoise-orm CI workflows - Added uv lock --check to all Python CI workflows to catch out-of-sync lock files Consolidated files - Moved `LICENSE_HEADER.txt` to repo root, removed per-project copies - Moved `.mise.toml` to repo root, removed per-project copies - Added pre-commit setup instructions to `CONTRIBUTING.md` This PR depends on #10, #11, and #12 to make the checks pass. Once those are merged I will mark this as ready for review. Until then, the checks will fail (as they are designed to do). By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies auto-formatting to Java files, in preparation for an upcoming change to the pre-commit checks.
We were previously enforcing formatting for the other subprojects, so I am combining those checks to run at the root level. I've split this change out to make the final diff smaller and isolate formating-only changes. There should be no functional difference before/after.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.