ISSUE-30: Delete SQS messages when S3 payload not found#78
Merged
Conversation
|
@ziyanli-amazon is there anyway of getting this reviewed and merged in as this is a delineation between V1 and V2 functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to bring back the fix for issue #30.
Description of changes
If client is configured with
ignorePayloadNotFoundset totrue, delete SQS messages that contain pointers to S3 objects that no longer exist on S3.Context
ignorePayloadNotFound, however this configuration option is never used which results in unexpected behaviour.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.