Upgrade to AWS SDK v2 by mngo87 · Pull Request #58 · awslabs/amazon-sqs-java-extended-client-lib

mngo87 · 2020-09-22T02:27:44Z

Issue #, if available:
#35

Description of changes:
Ensure this library is compatible with Java SDK V2

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mngo87 · 2020-09-22T02:28:48Z

+        ArgumentCaptor<DeleteMessageBatchRequest> deleteBatchRequestCaptor = ArgumentCaptor.forClass(DeleteMessageBatchRequest.class);
+        verify(mockSqsBackend, times(1)).deleteMessageBatch(deleteBatchRequestCaptor.capture());
+        DeleteMessageBatchRequest request = deleteBatchRequestCaptor.getValue();
+        Assert.assertEquals(originalReceiptHandles.size(), request.entries().size());


i improved the test to check that the receipt handles were getting passed along correctly

mngo87 · 2020-09-22T02:29:12Z

+        SendMessageRequest.Builder sendMessageRequestBuilder = sendMessageRequest.toBuilder();
+        sendMessageRequestBuilder.overrideConfiguration(
+            AwsRequestOverrideConfiguration.builder()
+                .putHeader(USER_AGENT_HEADER_NAME, USER_AGENT_HEADER)


please advise if this is not the best way to do this

mngo87 · 2020-09-23T15:58:18Z

Since I am unable to attach reviewers. Just mentioning some folks. @robin-aws @adam-aws @aws-rizi

prower-turnitin · 2021-03-10T17:55:12Z

Hi, I took a look your branch for this pull request. I'm interested in having a version of this which works with AWS SDK 2 for Java. Your using the old payloadoffloading-common which use the old aws sdk v1.

There is a new version of this which works with v2.

        <dependency>
            <groupId>software.amazon.payloadoffloading</groupId>
            <artifactId>payloadoffloading-common</artifactId>
            <version>2.1.1</version>
        </dependency>

I may fork this repo myself to create a version which works with sdk 2. I'm fairly certain the above lib will be required.

adam-aws · 2021-03-10T17:59:15Z

Hi @prower-turnitin , sorry for the late reply on this PR, yes we had previously refactored this library and moved some code out to payloadoffloading. We've added support to v2 in payloadoffloading so that we may eventually provide support for v2 for the extended client.
Yes you would need to use the payloadoffloading.

Thanks

cruizba · 2021-03-15T15:19:17Z

Hi @prower-turnitin , sorry for the late reply on this PR, yes we had previously refactored this library and moved some code out to payloadoffloading. We've added support to v2 in payloadoffloading so that we may eventually provide support for v2 for the extended client.
Yes you would need to use the payloadoffloading.

Thanks

That would be great!! Is there any ETA for the aws sdk v2 support?

Thanks in advance

cemo · 2021-05-01T19:32:39Z

@adam-aws Would you please release new version of this library which depends on sdk2? We are ending up in our classpath mixed version of v1 and v2.

eddy-aws · 2021-08-23T17:13:46Z

@@ -0,0 +1,58 @@
+<?xml version="1.0" encoding="UTF-8"?>


Please remove this file.

jordidomingo · 2021-09-22T13:17:42Z

Hi! Do you have an ETA for v2 @eddy-aws ? We are also blocked with this release. Thanks

eddy-aws · 2021-09-22T18:24:43Z

+            .queueUrl(SQS_QUEUE_URL)
+            .messageBody(messageBody)
+            .overrideConfiguration(
+                AwsRequestOverrideConfiguration.builder()


can we move this overrider to a helper method so that we can reuse it in other places?

eddy-aws · 2021-09-22T18:40:42Z

-        AmazonS3 s3 = mock(AmazonS3.class);
-        when(s3.putObject(isA(PutObjectRequest.class))).thenReturn(null);
+        S3Client s3 = mock(S3Client.class);
+//        when(s3.putObject(isA(PutObjectRequest.class))).thenReturn(null);


This line should be removed.

eddy-aws · 2021-09-22T18:41:03Z

-        AmazonS3 s3 = mock(AmazonS3.class);
-        when(s3.putObject(isA(PutObjectRequest.class))).thenReturn(null);
+        S3Client s3 = mock(S3Client.class);
+//        when(s3.putObject(isA(PutObjectRequest.class))).thenReturn(null);


Please remove the comments

eddy-aws · 2021-09-22T18:49:52Z

+//        S3Object s3Object = S3Object.builder().build();
+//        s3Object.setObjectContent(new StringInputStream(expectedMessage));


Please remove

juandavidg890121 · 2021-09-27T12:32:55Z

@mngo87 please review the comments we are blocked with this release

eddy-aws · 2021-09-27T21:05:37Z

We can send a new PR for those comments. To unblock the customer, let's proceed and merge the PR.

juandavidg890121 · 2021-09-27T21:33:52Z

We can send a new PR for those comments. To unblock the customer, let's proceed and merge the PR.

the branch has some problems with deprecated methods like withLargePayloadSupportEnabled or withPayloadSizeThreshold should be changed for withPayloadSupportEnabled and withPayloadSizeThreshold

method sendMessageBatch obtain the entries but never set to the sendMessageBatchRequest, something like the following should be done:
sendMessageBatchRequestBuilder.entries(batchEntries); sendMessageBatchRequest = sendMessageBatchRequestBuilder.build();

also the tests do not run due to dependency error
`java.lang.NoClassDefFoundError: com/fasterxml/jackson/databind/ObjectMapper

at software.amazon.payloadoffloading.JsonDataConverter.<init>(JsonDataConverter.java:19)
at software.amazon.payloadoffloading.PayloadS3Pointer.toJson(PayloadS3Pointer.java:35)`

all these changes I put in a local branch and tested

Note: versions of aws-java-sdk, junit and mockito could be increased

Upgrade to AWS SDK v2

1aafed9

mngo87 commented Sep 22, 2020

View reviewed changes

mngo87 mentioned this pull request Sep 24, 2020

Upgrade to AWS SDK v2 awslabs/amazon-sns-java-extended-client-lib#6

Merged

Merge branch 'master' into v2

055bae5

jordanst3wart mentioned this pull request Aug 6, 2021

This library is not well maintained. Can it be hosted by somebody else, or given more attention please? #63

Open

Make use of the Payload Offloading library v2

95e9583

eddy-aws reviewed Aug 23, 2021

View reviewed changes

adam-aws and others added 3 commits August 31, 2021 12:15

remove iml file

05e0ee7

Update how we appendUserAgent

42c0961

Merge branch 'master' into v2

dc609af

adam-aws requested a review from eddy-aws September 2, 2021 17:42

eddy-aws reviewed Sep 22, 2021

View reviewed changes

Merge branch 'master' into v2

7b76277

adam-aws merged commit 129daf5 into awslabs:master Sep 27, 2021

thread-sleep mentioned this pull request Sep 16, 2022

ISSUE-30: Delete SQS messages when S3 payload not found #78

Merged

		// S3Object s3Object = S3Object.builder().build();
		// s3Object.setObjectContent(new StringInputStream(expectedMessage));

Conversation

mngo87 commented Sep 22, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mngo87 commented Sep 23, 2020

Uh oh!

prower-turnitin commented Mar 10, 2021

Uh oh!

adam-aws commented Mar 10, 2021

Uh oh!

cruizba commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cemo commented May 1, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jordidomingo commented Sep 22, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juandavidg890121 commented Sep 27, 2021

Uh oh!

eddy-aws commented Sep 27, 2021

Uh oh!

juandavidg890121 commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cruizba commented Mar 15, 2021 •

edited

Loading

juandavidg890121 commented Sep 27, 2021 •

edited

Loading