Conversation
meyertst-aws
reviewed
Jan 2, 2024
Contributor
meyertst-aws
left a comment
There was a problem hiding this comment.
I think the READMEs need to be updated.
For example, the Secrets Manager README.
meyertst-aws
approved these changes
Jan 3, 2024
This reverts commit e5b034d.
meyertst-aws
pushed a commit
to meyertst-aws/aws-doc-sdk-examples
that referenced
this pull request
Jan 4, 2024
…unused files (awsdocs#5797) * Updates to remove Python examples for SecretsManager * Python formatting * Python fixes * Python fixes * Python fixes * fixes * test * Revert "test" This reverts commit e5b034d. * newline * removed unique name suffixes * removed unique name suffixes * black formatting
max-webster
pushed a commit
to max-webster/aws-doc-sdk-examples
that referenced
this pull request
Mar 15, 2024
…unused files (awsdocs#5797) * Updates to remove Python examples for SecretsManager * Python formatting * Python fixes * Python fixes * Python fixes * fixes * test * Revert "test" This reverts commit e5b034d. * newline * removed unique name suffixes * removed unique name suffixes * black formatting Incorporate changes for Aurora Serverless v2 to Aurora examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue with the existing secrets manager examples that need to be deleted. It removes roughly 500 lines of code.