Skip to content

fix(event_sources): change partition and offset field types in KafkaEventRecord#4515

Merged
leandrodamascena merged 1 commit intoaws-powertools:developfrom
scampbell5:bug/fix-kafka-event-record-types
Jun 13, 2024
Merged

fix(event_sources): change partition and offset field types in KafkaEventRecord#4515
leandrodamascena merged 1 commit intoaws-powertools:developfrom
scampbell5:bug/fix-kafka-event-record-types

Conversation

@scampbell5
Copy link
Copy Markdown

@scampbell5 scampbell5 commented Jun 13, 2024 •
edited by leandrodamascena
Loading

Issue number: #4504

Summary

Changes

Updated offset and partition properties to be an int type instead of str on the KafkaEventRecord class.

User experience

from aws_lambda_powertools.utilities.data_classes import event_source, KafkaEvent

@event_source(data_class=KafkaEvent)
def lambda_handler(event: KafkaEvent, context):
    assert isinstance(event.record.offset, int)
    assert isinstance(event.record.partition, int)

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@scampbell5 scampbell5 requested a review from a team June 13, 2024 22:54
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Jun 13, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@scampbell5 scampbell5 mentioned this pull request Jun 13, 2024
Closed
@scampbell5 scampbell5 changed the title fix: Change partition and offset on the KafkaEventRecord to be an int… fix(event_sources): Change partition and offset on the KafkaEventRecord to be an int… Jun 13, 2024
@leandrodamascena leandrodamascena linked an issue Jun 13, 2024 that may be closed by this pull request
Bug: KafkaEventRecord Incorrect types for offset and partition properties #4504
Closed
@leandrodamascena leandrodamascena changed the title fix(event_sources): Change partition and offset on the KafkaEventRecord to be an int… fix(event_sources): change partition and offset field types in KafkaEventRecord Jun 13, 2024
@github-actions github-actions bot added the bug Something isn't working label Jun 13, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (e14e768) to head (cf74437).
Report is 571 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4515      +/-   ##
===========================================
+ Coverage    96.38%   96.43%   +0.05%     
===========================================
  Files          214      219       +5     
  Lines        10030    10626     +596     
  Branches      1846     1976     +130     
===========================================
+ Hits          9667    10247     +580     
- Misses         259      267       +8     
- Partials       104      112       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

leandrodamascena
leandrodamascena approved these changes Jun 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR so quickly @scampbell5!

APPROVED!

@leandrodamascena leandrodamascena merged commit e54cabd into aws-powertools:develop Jun 13, 2024
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Jun 13, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrodamascena leandrodamascena leandrodamascena approved these changes

Assignees

No one assigned

Labels

bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: KafkaEventRecord Incorrect types for offset and partition properties

2 participants

@scampbell5 @leandrodamascena