fix(metrics): AttributeError raised by MetricManager and Typing and docs#357
Merged
heitorlessa merged 8 commits intoaws-powertools:developfrom Mar 25, 2021
Merged
Conversation
added 3 commits
March 24, 2021 00:32
Changes: - Correct typing to make mypy happier - Correct highlighted lines
Contributor
Author
|
@heitorlessa MyPy found a bug for us :) |
added 3 commits
March 24, 2021 21:04
Changes: - Use sys.version_info to determine where we need typing_extensions Reference: https://mypy.readthedocs.io/en/stable/runtime_troubles.html#using-new-additions-to-the-typing-module
Codecov Report
@@ Coverage Diff @@
## develop #357 +/- ##
========================================
Coverage 99.94% 99.94%
========================================
Files 96 96
Lines 3642 3643 +1
Branches 174 175 +1
========================================
+ Hits 3640 3641 +1
Partials 2 2
Continue to review full report at Codecov.
|
heitorlessa
suggested changes
Mar 25, 2021
Contributor
heitorlessa
left a comment
There was a problem hiding this comment.
Looks great!!!!! Asking two minor changes only
heitorlessa
approved these changes
Mar 25, 2021
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Apr 4, 2021
* develop: fix(idempotent): Correctly raise IdempotencyKeyError (#378) feat(event-handler): Add AppSync handler decorator (#363) feat(parameter): add dynamodb_endpoint_url for local_testing (#376) fix(parser): S3Model support empty keys (#375) fix(data-classes): Add missing operationName (#373) fix: perf tests for Logger and fail str msgs feat(parser): Add S3 Object Lambda Event (#362) build(pre-commit): Add pre-commit to make pr (#368) fix(tracer): Correct type hint for MyPy (#365) fix(metrics): AttributeError raised by MediaManager and Typing and docs (#357) Signed-off-by: heitorlessa <lessa@amazon.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Changes:
Before
After
and ignore missing imports:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.