[PATCH] Add safety check for bedrock ConverseStream responses#547
Merged
[PATCH] Add safety check for bedrock ConverseStream responses#547
Conversation
0c3d4ba to
a3109c8
Compare
mxiamxia
reviewed
Dec 2, 2025
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/patches/_botocore_patches.py
Outdated
Show resolved
Hide resolved
mxiamxia
approved these changes
Dec 2, 2025
yiyuan-he
pushed a commit
to yiyuan-he/aws-otel-python-instrumentation
that referenced
this pull request
Dec 12, 2025
…servability#547) *Description of changes:* Ports the changes from open-telemetry/opentelemetry-python-contrib#3990 Add defensive check for Bedrock responses missing expected structure. When no messageStart event with assistant role is received, the response may lack the standard output.message format, causing the occasional KeyError exceptions. For testing, I was unable to reproduce the exact scenario that would trigger this bug, however, this safety check would fix this issue without affecting normal instrumentation behavior. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
yiyuan-he
added a commit
to yiyuan-he/aws-otel-python-instrumentation
that referenced
this pull request
Dec 12, 2025
Merged
yiyuan-he
added a commit
that referenced
this pull request
Dec 12, 2025
*Issue #, if available:* N/A - Patch release preparation **Description of changes:** Cherry-pick commits from main to prepare v0.14.1 patch release: - #554 - Add custom ADOT UserAgent for OTLP Spans Exporter - #552 - Refactor configuration for Application Signals Dimensions to EMF exporter - #551 - CVE-2025-66471 fix (urllib3 dependency bump) - #549 - Disable django instrumentation if DJANGO_SETTINGS_MODULE is not set - #548 - Add Service and Environment dimensions to EMF metrics - #547 - Add safety check for bedrock ConverseStream responses - #546 - Fix python package distribution name case-sensitive issue By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --------- Co-authored-by: Lei Wang <66336933+wangzlei@users.noreply.github.com> Co-authored-by: Steve Liu <liustve@amazon.com> Co-authored-by: Syed Ahsan Ishtiaque <176968742+syed-ahsan-ishtiaque@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Ports the changes from open-telemetry/opentelemetry-python-contrib#3990
Add defensive check for Bedrock responses missing expected structure. When no messageStart event with assistant role is received, the response may lack the standard output.message format, causing the occasional KeyError exceptions.
For testing, I was unable to reproduce the exact scenario that would trigger this bug, however, this safety check would fix this issue without affecting normal instrumentation behavior.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.