Fix dependency conflicts in Python sample app with ADOT Python v1.37.0#486
Merged
lukeina2z merged 1 commit intoaws-observability:mainfrom Nov 4, 2025
lukeina2z:pr-python-app
Merged
Fix dependency conflicts in Python sample app with ADOT Python v1.37.0#486lukeina2z merged 1 commit intoaws-observability:mainfrom lukeina2z:pr-python-app
lukeina2z merged 1 commit intoaws-observability:mainfrom
lukeina2z:pr-python-app
Conversation
Problem: ADOT Python E2E tests failed after upgrading ADOT Python’s upstream dependency from v1.33.1 to v1.37.0. Cause: The Python sample app incorrectly specifies a fixed version of opentelemetry-sdk (v1.33.1) as a dependency, even though it does not rely on that package. This introduces a version conflict with the updated ADOT Python and prevents signal generation. Additionally, opentelemetry-api is pinned to a fixed version, causing further conflicts with ADOT Python. For the sample app, any v1 API package should be compatible. Fix: Removed opentelemetry-sdk from the dependency list. Relaxed opentelemetry-api version constraint to >=1.33.1,<2.0.0. Test: Ran Python sample app without ADOT → Pass. Ran Python sample app with ADOT → Pass. Triggered Python EC2 E2E test → Pass.
Contributor
|
LGTM |
majanjua-amzn
approved these changes
Nov 4, 2025
lukeina2z
pushed a commit
to aws-observability/aws-otel-python-instrumentation
that referenced
this pull request
Nov 4, 2025
This reverts commit bf43ed0. *Issue #, if available:* The blocking issue of upgrade OTel Python to v1.37.0 has been fixed in the E2E test app: Fix dependency conflicts in Python sample app with ADOT Python v1.37.0 aws-observability/aws-application-signals-test-framework#486 *Description of changes:* Revert the "revert" #529. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
ADOT Python E2E tests failed after upgrading ADOT Python’s upstream dependency from v1.33.1 to v1.37.0.
Cause:
The Python sample app incorrectly specifies a fixed version of opentelemetry-sdk (v1.33.1) as a dependency, even though it does not rely on that package. This introduces a version conflict with the updated ADOT Python and prevents signal generation.
Additionally, opentelemetry-api is pinned to a fixed version, causing further conflicts with ADOT Python. For the sample app, any v1 API package should be compatible.
Fix:
Removed opentelemetry-sdk from the dependency list. Relaxed opentelemetry-api version constraint to >=1.33.1,<2.0.0.
Test:
Ran Python sample app without ADOT → Pass.
Ran Python sample app with ADOT → Pass.
Triggered Python EC2 E2E test → Pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.