Merged
Conversation
dougch
approved these changes
Feb 12, 2026
WesleyRosenblum
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Reduce sidetrail runtime from 40min back to 15min.
Why
We recently noticed a huge leap in sidetrail runtimes, from 15min to 40min after PR #5719.
How
I initialized the fields of the extension bitfield in the proof setup on the advice of the automated reasoning team. These fields don't change the behavior of the s2n_cbc_verify function, which is what we're trying to prove anyways. The function doesn't even touch these connection fields.
Callouts
I think this solution is strictly better than #5727, where we're locking the proof to 15 loop unrolls.
Testing
The runtime in the general batch for the sidetrail test is now 10 minutes.
Related
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.