chore: Delete all code that references Kyber#5705
Merged
Conversation
7b38a03 to
7820197
Compare
maddeleine
reviewed
Jan 16, 2026
dougch
approved these changes
Jan 21, 2026
Contributor
dougch
left a comment
There was a problem hiding this comment.
Nice! it might also be worth calling out dropping OQS...
maddeleine
reviewed
Jan 23, 2026
Merged
51fa16c to
3c5974d
Compare
maddeleine
approved these changes
Feb 11, 2026
dougch
approved these changes
Feb 16, 2026
8412369 to
49a9609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Removes any reference that Kyber ever existed from s2n-tls's codebase.
Why
How
grep -ni kyber -r .in the s2n-tls directory and deleted everything I could find.Callouts
20240730which was previously pointed to bydefault_pq. I don't think that will cause any issues, but wanted to call that out for others to confirm.test_all_fipswas updated to add all MLKEM KeyShares sincekem_preferences_allis now FIPS compliant.crypto/s2n_fips_rules.cso that pure ML-KEM-1024 would be detected as FIPS.Testing
Unit Testing on M4 Mac.
Related
Related to:
release summary: Delete all code that references Kyber
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.