chore: Mark Kyber as unsupported on all LibCrypto variants#5701
Merged
chore: Mark Kyber as unsupported on all LibCrypto variants#5701
Conversation
8cd1ced to
65e8153
Compare
65e8153 to
fd119df
Compare
jmayclin
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Remove all usages of Kyber NID's and all LibCrypto dependencies on Kyber
Why
Allow AWS-LC to delete all of their Kyber code.
How
Replace all Kyber LibCrypto NIDS with
NID_undef. This will cause Kyber to be detected as unsupported on all LibCrypto variants becauses2n_kem_is_available()will now always return false.Other Changes
Callouts
Lots of existing Kyber code in s2n remains, but it is dead code due to
s2n_kem_is_available()never returning true for any Kyber-based KEMs on any LibCrypto's.Testing
Unit tests on M4 Mac
Related
Resolves #5699
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.