tests(integration): cases for TLS 1.3 group selection#5652
Merged
tests(integration): cases for TLS 1.3 group selection#5652
Conversation
jmayclin
commented
Dec 5, 2025
bindings/rust/standard/integration/src/features/group_negotiation.rs
Outdated
Show resolved
Hide resolved
bindings/rust/standard/integration/src/features/group_negotiation.rs
Outdated
Show resolved
Hide resolved
bindings/rust/standard/integration/src/features/group_negotiation.rs
Outdated
Show resolved
Hide resolved
kaukabrizvi
approved these changes
Dec 5, 2025
| pair.shutdown().unwrap(); | ||
|
|
||
| let decrypted_stream = pair.io.decrypter.borrow(); | ||
| let transcript = decrypted_stream.as_ref().unwrap().transcript(); |
Contributor
There was a problem hiding this comment.
Love this! Being able to decrypt and inspect the full transcript directly makes these tests precise and easy to reason about.
CarolYeh910
approved these changes
Dec 5, 2025
kaukabrizvi
pushed a commit
to kaukabrizvi/s2n-tls
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add a test for group selection logic
Why
We just added another lever for s2n-tls group selection logic. Our existing unit/integration tests are quite verbose and difficult to read, so there is benefit in being able to have some concise tests that show exactly what the s2n-tls behavior is, and which demonstrate that without relying on any internal APIs.
How
We use
brass-aphid-wireto access a very neat "TLS Transcript" of the handshake, which lets us look at the key shares/selected groups without actually querying the underlying TLS connectionsTesting
This is a test 🙂
I did make sure that the test failed when I changed the assertions.
Related
strongly preferred groups: #5648
brass-aphid-wire integration: #5634
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.