refactor(aws-kms-tls-auth): add hmac based psk derivation#5519
Merged
refactor(aws-kms-tls-auth): add hmac based psk derivation#5519
Conversation
lrstewart
reviewed
Sep 22, 2025
goatgoose
reviewed
Sep 23, 2025
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com> Co-authored-by: Lindsay Stewart <stewart.r.lindsay@gmail.com>
* fix leftover stuff from refactor
* remove unused import
lrstewart
approved these changes
Sep 23, 2025
goatgoose
approved these changes
Sep 24, 2025
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
* remove outdated comment
dougch
pushed a commit
to dougch/s2n-tls
that referenced
this pull request
Sep 26, 2025
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com> Co-authored-by: Lindsay Stewart <stewart.r.lindsay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds a new method for deriving PSK's from the KMS
generateMacAPI.This significantly reduces the required TPS to KMS, and will allow O(N) scaling characteristics.
Derivation and Epoch structures is described in module documentation.
Testing:
New unit tests are added.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.