feat(integration): add utilities for capability assertions#5475
Merged
feat(integration): add utilities for capability assertions#5475
Conversation
0535879 to
484f497
Compare
484f497 to
27d1383
Compare
lrstewart
reviewed
Aug 22, 2025
goatgoose
reviewed
Aug 22, 2025
jmayclin
commented
Aug 22, 2025
| // shutdown must be called for session resumption to work | ||
| // https://www.openssl.org/docs/man1.1.1/man3/SSL_set_session.html | ||
| self.connection.shutdown().unwrap(); | ||
| let _ = self.connection.shutdown(); |
* use static capability configuration
goatgoose
approved these changes
Aug 26, 2025
lrstewart
approved these changes
Aug 26, 2025
* log whenever we fall back to the default awslc detection
* rustfmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Goal
Allow integration tests to gracefully handle the different capabilities of s2n-tls when different libcryptos are linked.
Why
We are preparing to run the integration tests with a wider variety of libcryptos, and this is a prerequisite for that.
How
This PR adds a harness/wrapper that will
Testing:
I tested this with various cryptos. When in the nix devshell you can now run
rust_integrationto run the rust integration tests with the current libcrypto.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.