Skip to content

refactor(tls-harness): avoid implicit shutdown of ossl connection#5474

Merged
jmayclin merged 3 commits intoaws:mainfrom
jmayclin:2025-08-21-shutdown-fix
Aug 26, 2025
Merged

refactor(tls-harness): avoid implicit shutdown of ossl connection#5474
jmayclin merged 3 commits intoaws:mainfrom
jmayclin:2025-08-21-shutdown-fix

Conversation

@jmayclin
Copy link
Copy Markdown
Contributor

Description of changes:

Previously, we hackily called "shutdown" on the openssl connection to ensure that the session ticket was valid.

Now that we have actual shutdown utilities we can deal with this more cleanly by just calling ".shutdown()" when the ticket is generated.

Remember:

  • Any change to the library source code should at least include unit tests.
  • Any change to the core stuffer or blob methods should include CBMC proofs.
  • Any change to the CI or tests should:
    1. prove that the test succeeds for good input
    2. prove that the test fails for bad input (eg, a test for memory leaks fails when a memory leak is committed)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Aug 21, 2025
* shutdown the connection for session ticket generation
@jmayclin jmayclin requested a review from goatgoose August 26, 2025 18:10
@jmayclin jmayclin enabled auto-merge August 26, 2025 18:10
@jmayclin jmayclin added this pull request to the merge queue Aug 26, 2025
Merged via the queue into aws:main with commit a1f050a Aug 26, 2025
50 checks passed
@jmayclin jmayclin deleted the 2025-08-21-shutdown-fix branch August 26, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants