Skip to content

docs: Add security comment to ISSUE_TEMPLATE#2167

Merged
dougch merged 1 commit intoaws:masterfrom
dougch:issute_template_security
Jul 23, 2020
Merged

docs: Add security comment to ISSUE_TEMPLATE#2167
dougch merged 1 commit intoaws:masterfrom
dougch:issute_template_security

Conversation

@dougch
Copy link
Copy Markdown
Contributor

@dougch dougch commented Jul 22, 2020

Resolved issues:

Internal

Description of changes:

Copy the security reporting wording from the README to the issue template.

Also, Update to newer GitHub template format.

Call-outs:

There is the option of creating distinct issue templates for Bugs vs Features, for now, just went with Custom to reduce confusion and duplication.

Testing:

Added to my fork.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dougch dougch requested review from lrstewart and zaherd July 22, 2020 18:54

### Problem:

A short description of what the problem is and why we need to fix it. Add reproduction steps if necessary.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're updating this, could you also add newlines after each section? It's annoying to replace the text when the next title is on the next line.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 22, 2020

Codecov Report

Merging #2167 into master will decrease coverage by 0.02%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master    #2167      +/-   ##
==========================================
- Coverage   81.09%   81.07%   -0.03%     
==========================================
  Files         248      248              
  Lines       18497    18505       +8     
==========================================
+ Hits        15001    15003       +2     
- Misses       3496     3502       +6     

Impacted file tree graph

- Update to newer GitHub template format.
@dougch dougch force-pushed the issute_template_security branch from 1829f01 to a09edbc Compare July 22, 2020 22:01
@dougch dougch requested a review from lrstewart July 22, 2020 22:02
Comment on lines +3 to +7
name: S2N Issue
about: Template
title: ''
labels: ''
assignees: ''
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these values required? For assignees the github UI allows us to add with the drop-down options. This would be a duplication in that respect.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These allow us to pre-populate the Template, and with GitHub's new template system, we could have one template for bugs that has a pre-populated title [BUG] and a feature request template that has title: '[FEATURE]', as an example.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add-on! We could probably track a list of keywords like [BUG], [FEATURE] that would trigger our alarms :)

@ttjsu-aws
Copy link
Copy Markdown
Contributor

Looks like you would have to rebase your PR to obtain the latest fix for sidetrail #2170.

@dougch dougch merged commit e4310b5 into aws:master Jul 23, 2020
dougch added a commit that referenced this pull request Jul 23, 2020
dougch added a commit that referenced this pull request Jul 23, 2020
Duplicate of #2167 - GitHub wants these changes via the UI
dougch added a commit that referenced this pull request Jul 23, 2020
Duplicate of #2167 - GitHub wants these changes via the UI
@dougch dougch deleted the issute_template_security branch March 3, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants