Merged
Conversation
This was working previously because the Openssl libcrypto implementation calls SHA512_Final directly from SHA384_Final. What if this changes? I don't think the increase in confusion here justifies the decrease in stack depth. fixes aws#157
Contributor
Author
|
Has anyone noticed transient unit test failures? I noticed this failure would pop up randomly when I was doing some local development on a previous pull request. Now it appears in the TravisCI build output. Neither this change nor the previous change I was working on should cause this to fail...could be a bug? |
Contributor
|
I have a fix for this in #192 , where time is now mocked and set explicitly to handle the fact that time is screwy on the travis boxes. Feel free to CR and merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was working previously because the Openssl libcrypto implementation
calls SHA512_Final directly from SHA384_Final. What if this changes?
I don't think the increase in confusion here justifies the decrease
in stack depth.
fixes #157