fix(ci): copyright check improvement#2890
Merged
boquan-fang merged 3 commits intoaws:mainfrom Nov 10, 2025
Merged
Conversation
* remove the Amazon's copyright statement, but keep the copyright's word at top.
This reverts commit 2ebfdb4.
CarolYeh910
approved these changes
Nov 10, 2025
Contributor
Author
|
The |
boquan-fang
added a commit
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
resolves #2889.
Description of changes:
Instead of checking for the word
Copyrightin our CI, we should check the phraseCopyright Amazon.com, Inc. or its affiliates.to ensure all files contain Amazon's copyright statement.Call-outs:
I add the
-ioption to the command, because case distinction shouldn't affect this check. In fact, we do have at least one file that is usingcopyright Amazon.com, Inc. or its affiliates:s2n-quic/tools/xdp/s2n-quic-xdp/src/if_xdp.rs
Line 3 in cf77e2b
Testing:
Local test: I removed the Amazon copy right statement in
if_xdp.rs. The file would still have the wordCopyrightat the top, but this test will error:Github test: I remove that line on this PR to show that copy right will fail. I then revert the commit to pass the test.
Negative test: for commit: 2ebfdb4, the copyright test failed: https://github.com/aws/s2n-quic/actions/runs/19242825789/job/55009419600?pr=2890.
Positive test: I revert the negative test commit. The new commit is 31cefd6, the copyright test passed: https://github.com/aws/s2n-quic/actions/runs/19242880178/job/55009601767?pr=2890.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.