Conversation
8262ab9 to
a1b6875
Compare
boquan-fang
reviewed
Oct 31, 2025
| extends: ['@commitlint/config-conventional'], | ||
| rules: { | ||
| 'subject-case': [0], | ||
| 'body-max-line-length': [0], |
Contributor
There was a problem hiding this comment.
Should we limit the maximum length for the subject: https://commitlint.js.org/reference/rules.html#subject-max-length? We probably shouldn't allow a PR subject to be larger than one line.
Contributor
Author
There was a problem hiding this comment.
Let's address in a followup, I'm not sure what the right value is here and don't want to guess low.
Co-authored-by: Boquan Fang <boquanfang3@gmail.com>
0db242c to
3b637d2
Compare
boquan-fang
approved these changes
Nov 3, 2025
dougch
added a commit
to dougch/s2n-quic
that referenced
this pull request
Nov 7, 2025
ci: This reverts commit a243f2e.
dougch
added a commit
that referenced
this pull request
Nov 11, 2025
ci: This reverts commit a243f2e.
dougch
added a commit
to dougch/s2n-quic
that referenced
this pull request
Nov 11, 2025
ci: This reverts commit a243f2e.
dougch
added a commit
to dougch/s2n-quic
that referenced
this pull request
Nov 11, 2025
ci: This reverts commit a243f2e.
dougch
added a commit
that referenced
this pull request
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Description of changes:
GitHub Action to check the last commit for compliance with conventional commits.
Call-outs:
I've added a few types from the commit history to the config that aren't common:
optandinternal.Aiming for parity of the config with the https://github.com/aws/s2n-tls project.
Testing:
In this PR's history, you can see a force push that failed when I removed the
ci:prefix from the commit.local:
No output means the commit passed, but from the above output you can see that there are a few past commits that would have failed this check.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.