Skip to content

feat(jsii-reflect): add parent assembly reference to Submodule#4992

Merged
mergify[bot] merged 1 commit intomainfrom
mrgrain/feat/jsii-reflect/add-parent-assembly-reference
Nov 26, 2025
Merged

feat(jsii-reflect): add parent assembly reference to Submodule#4992
mergify[bot] merged 1 commit intomainfrom
mrgrain/feat/jsii-reflect/add-parent-assembly-reference

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Nov 26, 2025

This PR adds a parent property to the Submodule class that references the parent Assembly. This enables submodules to access their parent assembly context, which is useful for navigating the module hierarchy.

Changes

  • Added parent: Assembly property to Submodule class
  • Updated SubmoduleBuilder to accept and pass the parent assembly reference
  • Added import for Assembly in submodule.ts

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add a parent property to the Submodule class that references the parent Assembly.
This enables submodules to access their parent assembly context.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 26, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 26, 2025

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Nov 26, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 26, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 7 seconds in the queue, with no time waiting for CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • status-success=Integration test (jsii-pacmak)
  • status-success=Unit Tests
  • any of [🛡 GitHub branch protection]:
    • check-success = Integration test (jsii-pacmak)
    • check-neutral = Integration test (jsii-pacmak)
    • check-skipped = Integration test (jsii-pacmak)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build
    • check-neutral = Build
    • check-skipped = Build
  • any of [🛡 GitHub branch protection]:
    • check-success = Unit Tests
    • check-neutral = Unit Tests
    • check-skipped = Unit Tests

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 26, 2025

Merging (with squash)...

@mergify mergify bot added the queued label Nov 26, 2025
@mergify mergify bot merged commit 1232932 into main Nov 26, 2025
39 checks passed
@mergify mergify bot deleted the mrgrain/feat/jsii-reflect/add-parent-assembly-reference branch November 26, 2025 19:01
@mergify mergify bot removed pr/ready-to-merge This PR is ready to be merged. queued labels Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants