Skip to content

feat(jsii-reflect): track directory and package.json for Assembly#4991

Merged
mergify[bot] merged 3 commits intomainfrom
huijbers/reflect-track-dir
Nov 26, 2025
Merged

feat(jsii-reflect): track directory and package.json for Assembly#4991
mergify[bot] merged 3 commits intomainfrom
huijbers/reflect-track-dir

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Nov 26, 2025

It's occasionally useful to track the source for a loaded Assembly (specifically in cdk-generate-synthetic-examples we need this info to accurately track "exports").

Attach it to the Assembly.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

It's occasionally useful to track the source for a loaded Assembly
(specifically in `cdk-generate-synthetic-examples` we need this info
now).

Attach it to the Assembly.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 26, 2025
Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 26, 2025

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Nov 26, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 26, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 18 seconds in the queue, including 1 second waiting for CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • status-success=Integration test (jsii-pacmak)
  • status-success=Unit Tests
  • any of [🛡 GitHub branch protection]:
    • check-success = Integration test (jsii-pacmak)
    • check-neutral = Integration test (jsii-pacmak)
    • check-skipped = Integration test (jsii-pacmak)
  • any of [🛡 GitHub branch protection]:
    • check-success = Build
    • check-neutral = Build
    • check-skipped = Build
  • any of [🛡 GitHub branch protection]:
    • check-success = Unit Tests
    • check-neutral = Unit Tests
    • check-skipped = Unit Tests

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 26, 2025

Merging (with squash)...

@mergify mergify bot added the queued label Nov 26, 2025
@mergify mergify bot merged commit 3232edf into main Nov 26, 2025
39 checks passed
@mergify mergify bot deleted the huijbers/reflect-track-dir branch November 26, 2025 15:30
@mergify mergify bot removed pr/ready-to-merge This PR is ready to be merged. queued labels Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants