feat(dotnet): improve metadata of NuGet packages#1112
Merged
mergify[bot] merged 2 commits intomasterfrom Dec 12, 2019
Merged
Conversation
Convert the `package.json` `keywords` into `PackageTags` in the NuGet metadata. This is applied on the packages hosted in this repository as well as generated code. The `keywords` section from `package.json` is now forwarded into the `.jsii` assembly to support this feature. At this point, could not find a way to carry these keywords/tags to Maven Central or PyPI, so only NuGet actually leverages those.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
approved these changes
Dec 11, 2019
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the
package.jsonkeywordsintoPackageTagsin the NuGetmetadata. This is applied on the packages hosted in this repository as
well as generated code.
The
keywordssection frompackage.jsonis now forwarded into the.jsiiassembly to support this feature.At this point, could not find a way to carry these keywords/tags to
Maven Central or PyPI, so only NuGet actually leverages those.
Fixes #170
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.