Fix issues identified by mypy.#6
Merged
mattsb42-aws merged 4 commits intoaws:masterfrom Jun 12, 2018
mattsb42-aws:mypy
Merged
Conversation
… but will normalize it and pass it on. Also, read(0) should actually return 0 bytes
Merged
lizroth
reviewed
Jun 11, 2018
|
|
||
| # exact single-shot, varying multiples | ||
| for size in (1, 2, 3, 4, 5, 6, 7, 222, 1024): | ||
| for size in (0, 1, 2, 3, 4, 5, 6, 7, 222, 1024): |
Contributor
There was a problem hiding this comment.
Per offline discussion, reminder to add negative (non--1) value to test_cases.
Also: can these be combined to some degree with the values on 139-140?
Member
Author
lizroth
approved these changes
Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Some minor mypy annotation tweaks to correctly describe behavior.
In running through the mypy results, however, it identified that there were a couple subtle issues with two methods:
read()should only accept anint, notNone. I updated this to behave correctly but let it continue to acceptNoneas input.__exit__()should explicitlyFalserather than just [falsey]None.CI run. Note: the py33 and py37 runs are broken in the Travis config. A fix for that is in #7 .
https://travis-ci.org/mattsb42-aws/base64io-python/builds/389402410
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.