test: add integration tests for CLI client#8689
test: add integration tests for CLI client#8689reedham-aws merged 6 commits intoaws:feat-buildkitfrom
Conversation
|
prob need to merge from develop for the chardet thing |
1d13e88 to
c4155ec
Compare
There was a problem hiding this comment.
would suggest to add a ARM64 test, and then mark one test -> x86/arm64 as https://github.com/aws/aws-sam-cli/blob/develop/CONTRIBUTING.md#tier-1-cross-platform-smoke-tests for running that test on finch / windows (to be added)
Done, I added as tier1, although not sure if this would have fallen more into the tier1_extra category. I think the testing of the CLI is important enough, not sure about the parameters. |
|
Integ test run: https://github.com/aws/aws-sam-cli/actions/runs/22508505787 |
| command_list += ["--debug"] | ||
|
|
||
| if use_buildkit: | ||
| command_list += ["--use-buildkit"] |
There was a problem hiding this comment.
Will there be change in VS Code extension for this feature? If so, should we have a negate version of this as well: --no-use-buildkit. This should be similar to
aws-sam-cli/samcli/commands/_utils/options.py
Line 852 in c95e0ac
There was a problem hiding this comment.
--no-use-buildkit exists in the implementation, is it required to be in the test options as well?
|
Latest integration test run: https://github.com/aws/aws-sam-cli/actions/runs/22595806682. I removed the ARM64 test because it wasn't working well in x86 environment. While BuildKit should technically support this, that's more testing a BuildKit feature than our implementation. I think QEMU needs to be set up in some way in the environment for it to fully work. Edit: All related and non-flaky tests are passing |
e4c0cab to
bacfe0c
Compare
|
Latest test run: https://github.com/aws/aws-sam-cli/actions/runs/22649580848 Before, the |
* feat: add support for using CLI container clients (#8661) * feat: add build_client * feat: add --use-buildkit option * feat: use build client when building with images * lint and format * feat: add command to cli * fix: use absolute path for dockerfile * test: add unit test for build_client * test: add unit test for build_context * fix: additional test fixes * fix: schema update * fix: remove hardcoded unix pathseps * fix: remove provenance and sbom from docker buildx * fix: refactor code to use SDKBuildClient This change also refactors a lot of docker specific things to be "container_client" rather than "docker_client". In addition, moving from instantiating the image build client in build context to lazily doing it in the app builder. * test: add additional unit tests * fix: fix error handling in CLIBuildClient * fix: reorder error handling in CLIImageBuilder * test: add integration tests for CLI client (#8689) * test: add basic integration test * test: more comprehensive integ tests * test: add arm64 test and mark as tier1 * fix: update dockerfile error messages * test: remove arm64 test * fix: allow finch without sudo
Integration test PR for buildkit/container CLI support.
Added a few parameterized tests for some image based tests, as well as just general tests for using the
--use-buildkitflag. Worth noting is that when using the CLI, there were a lot of resource warnings that the sockets were being left open. I couldn't figure out a fix to this, but I think they're harmless warnings so I ignored them.Implementation PR: #8661.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.