Uncomment cryptography dependency in Python build test fixtures#8667
Merged
licjun merged 2 commits intoaws:developfrom Feb 19, 2026
Merged
Uncomment cryptography dependency in Python build test fixtures#8667licjun merged 2 commits intoaws:developfrom
licjun merged 2 commits intoaws:developfrom
Conversation
reedham-aws
reviewed
Feb 19, 2026
Contributor
reedham-aws
left a comment
There was a problem hiding this comment.
There's a couple other places that have cryptography commented out. I'd imagine these need to be changed as well, but not totally sure:
aws-sam-cli/tests/integration/buildcmd/build_integ_base.py
Lines 746 to 752 in 8abd32b
A couple places in
test_build_cmd.py:aws-sam-cli/tests/integration/buildcmd/test_build_cmd.py
Lines 397 to 403 in 8abd32b
And lots of stuff related to layers (one example):
I just grep'd the code for cryptography, but then again some of this might not be useful
reedham-aws
approved these changes
Feb 19, 2026
Vandita2020
approved these changes
Feb 19, 2026
roger-zhangg
added a commit
to roger-zhangg/aws-sam-cli
that referenced
this pull request
Feb 20, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Fixes #8654
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.