Conversation
This was referenced Jan 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
- Coverage 95.80% 92.45% -3.35%
==========================================
Files 61 71 +10
Lines 8143 9812 +1669
Branches 0 9812 +9812
==========================================
+ Hits 7801 9072 +1271
- Misses 342 451 +109
- Partials 0 289 +289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0blu
reviewed
Jan 13, 2026
0blu
reviewed
Jan 13, 2026
0blu
reviewed
Jan 13, 2026
0blu
left a comment
There was a problem hiding this comment.
lgtm! 👍
I've tested the changes by compiling on my Windows 11 PC and executing a simple program in my Windows 7 VM.
fn main() {
let rng = SystemRandom::new();
let mut buffer = [0u8; 32];
if rng.fill(&mut buffer).is_err() {
println!("Error filling random bytes");
} else {
println!("Everything is okay");
println!("{:02X?}", buffer);
}
}cargo +nightly build --release --target x86_64-win7-windows-msvc -Zbuild-std
Used commits:
justsmth@929b3d6
justsmth/aws-lc@c7599cd
justsmth
added a commit
to aws/aws-lc
that referenced
this pull request
Jan 16, 2026
### Issues: Addresses #1997 ### Description of changes: `ProcessPrng` (from `bcryptprimitives.dll`) is only available on Windows 8+. So the current code fails at runtime on Windows 7 because `GetProcAddress` returns `NULL` and causes an `abort()`. This change defines `AWSLC_WINDOWS_7_COMPAT` when `_WIN32_WINNT <= _WIN32_WINNT_WIN7`. Then uses the existing `BCryptGenRandom` logic when it's is defined. * Related: aws/aws-lc-rs#1000 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
WillChilds-Klein
approved these changes
Jan 21, 2026
skmcgrail
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses aws/aws-lc#1997
Description of changes:
When targeting Windows 7, ensure that there's a definition for
_WIN32_WINNT).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.