Fuzzing test cases for PKCS#8 v2 support#763
Merged
skmcgrail merged 1 commit intoaws:pkcs8v2from Jan 23, 2023
Merged
Conversation
f8ced53 to
7ffafbe
Compare
samuel40791765
approved these changes
Jan 19, 2023
| @@ -21,6 +21,7 @@ fuzzer(privkey) | |||
| fuzzer(cert) | |||
| fuzzer(spki) | |||
| fuzzer(pkcs8) | |||
Contributor
There was a problem hiding this comment.
Not sure if we should rename this to pkcs8_v1, but the current version does correspond with EVP_marshal_private_key/EVP_marshal_private_key_v2
Member
Author
There was a problem hiding this comment.
I'm going to bias towards leaving it the same for now to stay consistent with BoringSSL upstream. Can revisit later if needed.
andrewhop
approved these changes
Jan 19, 2023
R3hankhan123
pushed a commit
to R3hankhan123/aws-lc
that referenced
this pull request
Aug 29, 2025
* Fix MacOS w/ CMake 4.0 build * Cleanup CI environment variable usage * MacOS - test w/ latest CMake * Refactor environment variable handling * Use release builds for cross. Per Wine/x86_64-pc-windows-gnu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds fuzzing coverage for the PKCS#8 v2 support. The inputs were seeded from the associated EVP_KEY tests cases added in the prior PKCS#8 pull request. I have broken up the fuzzing between pkcs8 and pkcs8_v2 to ensure the fuzzer can reach
EVP_marshal_private_key_v2rather then it potentially being unreachable if it was in a combined function testing bothEVP_marshal_private_keyandEVP_marshal_private_key_v2.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.