Merged
Conversation
ba7167d to
d4d9b10
Compare
7d6a06a to
ac6a284
Compare
ac6a284 to
c6c8d92
Compare
andrewhop
reviewed
Dec 21, 2022
andrewhop
reviewed
Dec 21, 2022
ssl/ssl_test.cc
Outdated
| thread.join(); | ||
| } | ||
| } | ||
| EXPECT_EQ(SSL_CTX_sess_misses(server_ctx_.get()), 255); |
Contributor
There was a problem hiding this comment.
Can you explain what this test is doing and why there is one less miss than timeout?
f74580e to
9a692d8
Compare
392b414 to
bbf68a5
Compare
bbf68a5 to
b94182b
Compare
andrewhop
previously approved these changes
Dec 22, 2022
Contributor
|
Does this take into account the session transfer feature? |
Contributor
Author
No, but good question. These were based on a customer ask from the same team, the counters provide valuable insight for them into SSL usage and interactions. |
dkostic
reviewed
Dec 22, 2022
dkostic
approved these changes
Dec 28, 2022
andrewhop
approved these changes
Jan 4, 2023
R3hankhan123
pushed a commit
to R3hankhan123/aws-lc
that referenced
this pull request
Aug 29, 2025
* Bump aws-lc-fips-sys to v0.13.4 * Symbols from macos-14-xlarge * Symbols from ubuntu-latest * Symbols from macos-13 * Symbols for aarch64-unknown-linux-musl * Symbols for aarch64-unknown-linux-gnu * Symbols for x86_64-unknown-linux-musl * Generated headers * Generated bindings from macos-14-xlarge * Generated bindings from ubuntu-latest * Generated bindings for aarch64-unknown-linux-musl * Generated bindings for aarch64-unknown-linux-gnu * Generated bindings from macos-13 * Generated bindings for x86_64-unknown-linux-musl --------- Co-authored-by: aws-lc-fips-sys-bindings-generator <aws-lc-github-bot@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
CryptoAlg-1462Description of changes:
This is an attempt to add back the ssl stat counters that were taken out from BoringSSL in these commits:
Call-outs:
Details can be found in the doc under the thread of the SIM
Testing:
WIP
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.