EVP PKCS#8 v2 Key Support for Ed25519 and X25519#718
Merged
skmcgrail merged 7 commits intoaws:pkcs8v2from Jan 11, 2023
Merged
Conversation
5829e50 to
e06b9f5
Compare
Member
Author
|
I'm now wondering if we should also separate out the changes to |
15e3707 to
1b4d78f
Compare
1b2c2e7 to
85e37c1
Compare
torben-hansen
previously approved these changes
Dec 22, 2022
Contributor
torben-hansen
left a comment
There was a problem hiding this comment.
LGTM, but fuzzing did something. I tried restarting it.
| } | ||
| return true; | ||
| })) { | ||
| EVP_PKEY_free(key); |
Contributor
There was a problem hiding this comment.
A lot of writing. Could a go-to work better here?
The base branch was changed.
8a13b33 to
2046b44
Compare
torben-hansen
approved these changes
Jan 10, 2023
dkostic
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds support for PKCS#8 v2 encoding and decoding of Ed25519 and X25519 keys to the
EVP_*APIs.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.