TLS Transfer Serialization Findings#3071
Merged
Conversation
torben-hansen
previously approved these changes
Mar 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3071 +/- ##
==========================================
- Coverage 78.38% 78.37% -0.01%
==========================================
Files 689 689
Lines 121129 121141 +12
Branches 16968 16971 +3
==========================================
- Hits 94948 94947 -1
- Misses 25287 25298 +11
- Partials 894 896 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
torben-hansen
approved these changes
Mar 5, 2026
sgmenda
approved these changes
Mar 6, 2026
justsmth
approved these changes
Mar 6, 2026
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 11, 2026
# Description * Fixes an over-read into TLS transfer serialization ASN.1 data and caps it to the appropriate amount. * Sets `key_update_pending` to the value that was actually deserialized. This originally was thought to be addressed in aws@26da017 but while deserialization was done, the value was still not being set. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
key_update_pendingto the value that was actually deserialized. This originally was thought to be addressed in 26da017 but while deserialization was done, the value was still not being set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.