Conversation
WillChilds-Klein
approved these changes
Mar 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3070 +/- ##
==========================================
- Coverage 78.37% 78.36% -0.01%
==========================================
Files 689 689
Lines 121078 121078
Branches 16966 16965 -1
==========================================
- Hits 94889 94884 -5
- Misses 25294 25297 +3
- Partials 895 897 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nebeid
approved these changes
Mar 4, 2026
geedo0
approved these changes
Mar 4, 2026
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 11, 2026
### Description of changes: gRPC recently landed a TLS Private Key Offload feature (grpc/grpc#41606) that gates BoringSSL-specific code paths behind `#ifdef OPENSSL_IS_BORINGSSL`. AWS-LC defines `OPENSSL_IS_AWSLC` instead, so gRPC doesn't recognize it as BoringSSL-compatible. This causes all 11 `TlsPrivateKeyOffloadTest` tests to fail at setup time because `grpc_tls_identity_pairs_add_pair_with_signer` returns `UnimplementedError`. Since AWS-LC is a BoringSSL fork and supports all the relevant APIs (e.g. `SSL_PRIVATE_KEY_METHOD`), we pass `-DOPENSSL_IS_BORINGSSL=1` via `CMAKE_C_FLAGS`/`CMAKE_CXX_FLAGS` when building gRPC. This enables the BoringSSL code paths that are correct for AWS-LC, including private key offload, optimized session caching, and type macros. ### Call-outs: All `OPENSSL_IS_BORINGSSL` checks in gRPC are preprocessor-level guards inside source files — there's no CMake-level source file selection based on BoringSSL detection, so the CFLAGS approach is safe. ### Testing: The gRPC integration test itself validates the fix — the 11 `TlsPrivateKeyOffloadTest` tests that were failing should now pass. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
nebeid
pushed a commit
to nebeid/aws-lc
that referenced
this pull request
Mar 23, 2026
### Description of changes: gRPC recently landed a TLS Private Key Offload feature (grpc/grpc#41606) that gates BoringSSL-specific code paths behind `#ifdef OPENSSL_IS_BORINGSSL`. AWS-LC defines `OPENSSL_IS_AWSLC` instead, so gRPC doesn't recognize it as BoringSSL-compatible. This causes all 11 `TlsPrivateKeyOffloadTest` tests to fail at setup time because `grpc_tls_identity_pairs_add_pair_with_signer` returns `UnimplementedError`. Since AWS-LC is a BoringSSL fork and supports all the relevant APIs (e.g. `SSL_PRIVATE_KEY_METHOD`), we pass `-DOPENSSL_IS_BORINGSSL=1` via `CMAKE_C_FLAGS`/`CMAKE_CXX_FLAGS` when building gRPC. This enables the BoringSSL code paths that are correct for AWS-LC, including private key offload, optimized session caching, and type macros. ### Call-outs: All `OPENSSL_IS_BORINGSSL` checks in gRPC are preprocessor-level guards inside source files — there's no CMake-level source file selection based on BoringSSL detection, so the CFLAGS approach is safe. ### Testing: The gRPC integration test itself validates the fix — the 11 `TlsPrivateKeyOffloadTest` tests that were failing should now pass. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
gRPC recently landed a TLS Private Key Offload feature (grpc/grpc#41606) that gates BoringSSL-specific code paths behind
#ifdef OPENSSL_IS_BORINGSSL. AWS-LC definesOPENSSL_IS_AWSLCinstead, so gRPC doesn't recognize it as BoringSSL-compatible. This causes all 11TlsPrivateKeyOffloadTesttests to fail at setup time becausegrpc_tls_identity_pairs_add_pair_with_signerreturnsUnimplementedError.Since AWS-LC is a BoringSSL fork and supports all the relevant APIs (e.g.
SSL_PRIVATE_KEY_METHOD), we pass-DOPENSSL_IS_BORINGSSL=1viaCMAKE_C_FLAGS/CMAKE_CXX_FLAGSwhen building gRPC. This enables the BoringSSL code paths that are correct for AWS-LC, including private key offload, optimized session caching, and type macros.Call-outs:
All
OPENSSL_IS_BORINGSSLchecks in gRPC are preprocessor-level guards inside source files — there's no CMake-level source file selection based on BoringSSL detection, so the CFLAGS approach is safe.Testing:
The gRPC integration test itself validates the fix — the 11
TlsPrivateKeyOffloadTesttests that were failing should now pass.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.