Skip to content

Remove dead declarations in public headers#3053

Merged
justsmth merged 2 commits intoaws:mainfrom
skmcgrail:symbol-cleanup
Mar 6, 2026
Merged

Remove dead declarations in public headers#3053
justsmth merged 2 commits intoaws:mainfrom
skmcgrail:symbol-cleanup

Conversation

@skmcgrail
Copy link
Copy Markdown
Member

Description

These symbols are declared in our public headers but are not actually defined anywhere in libcrypto or libssl.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.36%. Comparing base (092453f) to head (5ba1d39).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3053   +/-   ##
=======================================
  Coverage   78.36%   78.36%           
=======================================
  Files         689      689           
  Lines      121144   121144           
  Branches    16973    16974    +1     
=======================================
+ Hits        94935    94939    +4     
+ Misses      25314    25309    -5     
- Partials      895      896    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth disabled auto-merge March 6, 2026 19:29
@justsmth justsmth merged commit 453905d into aws:main Mar 6, 2026
448 of 455 checks passed
WillChilds-Klein pushed a commit to WillChilds-Klein/aws-lc that referenced this pull request Mar 11, 2026
# Description
These symbols are declared in our public headers but are not actually
defined anywhere in libcrypto or libssl.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.

Co-authored-by: Justin W Smith <103147162+justsmth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants