IWYU: guard stdint.h in fips_shared_support.c#3027
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3027 +/- ##
==========================================
- Coverage 78.35% 78.33% -0.02%
==========================================
Files 689 689
Lines 121010 121010
Branches 16992 16993 +1
==========================================
- Hits 94813 94799 -14
- Misses 25302 25316 +14
Partials 895 895 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
Feb 25, 2026
WillChilds-Klein
approved these changes
Mar 2, 2026
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 11, 2026
### Description of changes: Did a manual run with [include-what-you-use](https://include-what-you-use.org/) which reported that `#include <stdint.h>` was included always in `crypto/fipsmodule/fips_shared_support.c` even though it was only needed in when `-DFIPS=1` and `-DBUILD_SHARED_LIBS=1` are enabled. This moves the include into the guarded block where it is actually needed. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
nebeid
pushed a commit
to nebeid/aws-lc
that referenced
this pull request
Mar 23, 2026
### Description of changes: Did a manual run with [include-what-you-use](https://include-what-you-use.org/) which reported that `#include <stdint.h>` was included always in `crypto/fipsmodule/fips_shared_support.c` even though it was only needed in when `-DFIPS=1` and `-DBUILD_SHARED_LIBS=1` are enabled. This moves the include into the guarded block where it is actually needed. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Did a manual run with include-what-you-use which reported that
#include <stdint.h>was included always incrypto/fipsmodule/fips_shared_support.ceven though it was only needed in when-DFIPS=1and-DBUILD_SHARED_LIBS=1are enabled. This moves the include into the guarded block where it is actually needed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.