Various Small Additions to ACVP Tool#3024
Merged
nhatnghiho merged 10 commits intoaws:mainfrom Mar 9, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
==========================================
- Coverage 78.38% 78.37% -0.01%
==========================================
Files 689 689
Lines 121200 121215 +15
Branches 16979 16980 +1
==========================================
+ Hits 95001 95003 +2
- Misses 25304 25317 +13
Partials 895 895 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Feb 26, 2026
sgmenda
previously approved these changes
Mar 4, 2026
Contributor
sgmenda
left a comment
There was a problem hiding this comment.
lgtm. good catch on the wycheproof vectors!
justsmth
previously approved these changes
Mar 9, 2026
justsmth
approved these changes
Mar 9, 2026
sgmenda
approved these changes
Mar 9, 2026
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 11, 2026
### Issues: Addresses P355857148 ### Description of changes: This PR adds ACVP support for: - `RSA signaturePrimitive` - `RSA decryptionPrimitive` - `KAS-ECC-SSC onePassDh` - `ECDSA sigGen componentTest` ### Call-outs: Due to the random nature of ECDH and ECDSA sigGen, no expected vector was added for these 2. To review, please run the script locally to verify the result. ### Testing: Run `check_expected.go` on the new test vectors. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. --------- Co-authored-by: sanketh <sgmenda@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses P355857148
Description of changes:
This PR adds ACVP support for:
RSA signaturePrimitiveRSA decryptionPrimitiveKAS-ECC-SSC onePassDhECDSA sigGen componentTestCall-outs:
Due to the random nature of ECDH and ECDSA sigGen, no expected vector was added for these 2. To review, please run the script locally to verify the result.
Testing:
Run
check_expected.goon the new test vectors.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.