Conversation
| const Span<const uint8_t> info = args[3]; | ||
| const Span<const uint8_t> out_len_bytes = args[4]; | ||
|
|
||
| uint32_t out_len; |
Contributor
There was a problem hiding this comment.
warning: variable 'out_len' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| uint32_t out_len; | |
| uint32_t out_len = 0; |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3010 +/- ##
=======================================
Coverage 78.37% 78.38%
=======================================
Files 689 689
Lines 121148 121148
Branches 16973 16975 +2
=======================================
+ Hits 94948 94957 +9
+ Misses 25302 25297 -5
+ Partials 898 894 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgmenda
previously approved these changes
Feb 19, 2026
skmcgrail
requested changes
Feb 23, 2026
skmcgrail
requested changes
Feb 23, 2026
Member
skmcgrail
left a comment
There was a problem hiding this comment.
Have you tested this with the ACVP demo server?
Comment on lines
+73
to
+74
| EphemeralXHex string `json:"ephemeralPublicIutX,omitempty"` | ||
| EphemeralYHex string `json:"ephemeralPublicIutY,omitempty"` |
Member
There was a problem hiding this comment.
Suggested change
| EphemeralXHex string `json:"ephemeralPublicIutX,omitempty"` | |
| EphemeralYHex string `json:"ephemeralPublicIutY,omitempty"` | |
| EphemeralXHex hexEncodedByteString `json:"ephemeralPublicIutX,omitempty"` | |
| EphemeralYHex hexEncodedByteString `json:"ephemeralPublicIutY,omitempty"` |
Then you don't need to call hex.EncodeString(result[0]) etc.
Comment on lines
+168
to
+176
| iutId, err := hex.DecodeString(group.IutId) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| serverId, err := hex.DecodeString(group.ServerId) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
Member
There was a problem hiding this comment.
I'm confused these aren't hex values so why are you calling hex.DecodeString?
Contributor
Author
There was a problem hiding this comment.
As counter-intuitive as it sounds, they are hex values (as noted in the JSON specifications here). I'll change their type from string to hexEncodedByteString
| EphemeralXHex string `json:"ephemeralPublicIutX,omitempty"` | ||
| EphemeralYHex string `json:"ephemeralPublicIutY,omitempty"` | ||
|
|
||
| Dkm string `json:"dkm,omitempty"` |
Member
There was a problem hiding this comment.
Suggested change
| Dkm string `json:"dkm,omitempty"` | |
| Dkm hexEncodedByteString `json:"dkm,omitempty"` |
| {"auxFunctionName": "SHA2-384"}, | ||
| {"auxFunctionName": "SHA2-512"} | ||
| ], | ||
| "fixedInfoPattern": "algorithmId", |
Member
There was a problem hiding this comment.
This doesn't match the fixedInfoPattern you are constructing in Go?
| p += x.size(); | ||
|
|
||
| memcpy(fixed_info.get() + p, y.data(), y.size()); | ||
| p += y.size(); |
Contributor
There was a problem hiding this comment.
warning: Value stored to 'p' is never read [clang-analyzer-deadcode.DeadStores]
p += y.size();
^Additional context
util/fipstools/acvp/modulewrapper/modulewrapper.cc:2981: Value stored to 'p' is never read
p += y.size();
^
skmcgrail
approved these changes
Mar 6, 2026
sgmenda
approved these changes
Mar 6, 2026
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 11, 2026
### Issues: Addresses P355857148 ### Description of changes: This PR adds ACVP support for `KAS-ECC onePassDh and ephemeralUnified` ### Call-outs: Due to the random nature of ECDH, no expected vector was added. To review, please run the script locally to verify the result. ### Testing: Run `check_expected.go` on the new KAS-ECC test vectors. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. --------- Co-authored-by: Sanketh Menda <sgmenda@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses P355857148
Description of changes:
This PR adds ACVP support for
KAS-ECC onePassDh and ephemeralUnifiedCall-outs:
Due to the random nature of ECDH, no expected vector was added. To review, please run the script locally to verify the result.
Testing:
Run
check_expected.goon the new KAS-ECC test vectors.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.